Add last resolve time metric #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sercand please review this PR, Thanks |
sercand
reviewed
Jul 7, 2024
builder.go
Outdated
| @@ -283,6 +296,7 @@ func (k *kResolver) watch() error { | |||
| if hasMore { | |||
| k.handle(up.Object) | |||
| } else { | |||
| k.lastResolve.Set(float64(time.Since(k.lastResolveTime).Seconds())) | |||
There was a problem hiding this comment.
@lalalalatt do you achieve what do you want with this change or did your test it? I don't think that lastResolve will update frequently therefore what you will see is "0" on prometheus metrics.
|
@sercand Thanks for the correction. And now I have added a test for the ❯ go test . -v
=== RUN TestBuilder
0, address: 192.168.194.47:53
0, servername: kube-dns.kube-system
--- PASS: TestBuilder (0.02s)
+ === RUN TestResolveLag
+ 0, address: 192.168.194.47:53
+ 0, servername: kube-dns.kube-system
+ builder_test.go:93: client resolver lag: 2 s
+ --- PASS: TestResolveLag (2.01s)
=== RUN TestParseResolverTarget
--- PASS: TestParseResolverTarget (0.00s)
=== RUN TestParseTargets
--- PASS: TestParseTargets (0.00s)
PASS
ok github.com/sercand/kuberesolver/v5 |
|
I change the metric to record the latest groups:
- name: update_state_alerts
rules:
- alert: UpdateStateStale
expr: time() - last_update_state_time_seconds > 60
for: 1m
labels:
severity: critical
annotations:
summary: "UpdateState has not been called recently"
description: "It has been more than 60 seconds since the last UpdateState call." |
sercand
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the description in authzed/spicedb#422: